Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Updating model on paste, cut, undo & redo #167

Closed
wants to merge 1 commit into from

Conversation

JulienCabanes
Copy link

This is similar to #144 but it also takes care of cut, undo and redo actions.

@JulienCabanes JulienCabanes changed the title Fix model update on paste, cut, undo & redo Updatin model on paste, cut, undo & redo Sep 16, 2015
@JulienCabanes JulienCabanes changed the title Updatin model on paste, cut, undo & redo Updating model on paste, cut, undo & redo Sep 16, 2015
@ceilino
Copy link

ceilino commented Oct 12, 2015

+1

@deeg deeg mentioned this pull request Oct 16, 2015
@deeg
Copy link
Contributor

deeg commented Oct 17, 2015

I don't mind adding this in, but will those actions not also fire a change event? What is not working for you if those other events are not there?

They all seem to work fine for me.

@CyborgMaster
Copy link

The problem seems to be with context menu initiated copy and paste. In the current version if I highlight some text in the editor and then right click and select paste, the UI updates with the pasted text, but not the angular model. If I initiate the paste with Ctrl(Command)-V, the model does update. With @JulienCabanes's branch, it works with the right click context menu.

@deeg deeg closed this in 9d9e468 Dec 20, 2015
@CyborgMaster
Copy link

Excellent. Can we get a new version released? Then I can stop using @JulienCabanes's branch.

@deeg
Copy link
Contributor

deeg commented Dec 21, 2015

@CyborgMaster, I plan to do this tonight as I wanted to get one or two more fixes in before officially releasing a new version.

In the meantime you can tell bower to install the latest master branch:

bower install angular-ui-tinymce#master --save

or in your bower.json file:

"angular-ui-tinymce": "master"

@CyborgMaster
Copy link

Thanks! Looks like I should have just been a little more patient. My apologies.

@deeg
Copy link
Contributor

deeg commented Dec 28, 2015

Sorry for the delay, this time of year is crazy. A new release has been put out.

Hope you had a good holidays, and have a happy new year!

MGORO pushed a commit to MGORO/ui-tinymce that referenced this pull request Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants